Add mix-ins to allow external styling of data-table-cell elements #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th in a header and out.
Saulis
reviewed
Sep 21, 2016
|
I think this is necessary when using iron-data-table with shadow dom. Ordinary CSS selectors won't pierce the shadow dom, but CSS variables can. |
|
@Storyyeller See example here: http://jsbin.com/fetibiy/edit?html,output |
|
Oh, I see what you mean. I think my problem was that we were using ::content in our selectors, but the cells are not actually inside a content tag. |
|
I got it working now. Thanks for the help and sorry for bothering you. |
|
No problem at all, glad you got it working! 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds mix-ins to allow external styling of data-table-cell elements, both normal cells and those within a header.
--iron-data-table-cell--iron-data-table-header-cellThe change is primarily to allow resetting the size of header-cell height enabling the use of elements within the header that exceed the hard-coded height.
This change is